Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on browserify #36

Closed
benjamn opened this issue Oct 24, 2013 · 5 comments
Closed

Remove dependency on browserify #36

benjamn opened this issue Oct 24, 2013 · 5 comments

Comments

@benjamn
Copy link
Collaborator

benjamn commented Oct 24, 2013

We don't need browserify for anything except running the test suite in a browser, and it pulls in a ton of dependencies that slow down npm install considerably.

@ForbesLindesay
Copy link
Contributor

Why not use devDependencies. These are only installed when you explicitly run npm install in the regenerator directory. This means they don't add bloat to production, but can be safely used in unit tests. At the moment you have a dependency in your tests that isn't specified in package.json

@benjamn
Copy link
Collaborator Author

benjamn commented Oct 24, 2013

Do you know if Travis CI runs npm install in the package directory? Speeding up tests was one of the main motivations here.

I'm inclined to wait to add it back until browserify is actually necessary for running tests.

@ForbesLindesay
Copy link
Contributor

travis does, but you shouldn't be having a problem with travis build speed. I can't see how travis taking an extra 10 seconds or so can ever be a serious hindrance to development speed? You do however want to get rid of any dependencies that aren't needed at runtime so people don't have to install them when they just depend on regenerator.

mocha should never be an optionalDependency, since it's pretty much never needed at runtime.

@benjamn
Copy link
Collaborator Author

benjamn commented Oct 28, 2013

@ForbesLindesay wanna make a pull request to fix this up?

@ForbesLindesay
Copy link
Contributor

done in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants