Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next(value) call to newly created generator should throw TypeError #76

Closed
DavidBruant opened this issue Jan 15, 2014 · 4 comments
Closed

Comments

@DavidBruant
Copy link

Equivalent V8 issue https://code.google.com/p/v8/issues/detail?id=3099
Firefox implements proper behavior.

Relevant es-discuss post: https://mail.mozilla.org/pipermail/es-discuss/2014-January/035766.html

This will require reconsidering the check function of the test harness.

@benjamn
Copy link
Collaborator

benjamn commented Jan 15, 2014

Happy to rewrite check, but I would like to avoid testing this behavior until V8 behaves the right way, so that we can keep running exactly the same tests natively in Node v0.11.2+.

@benjamn
Copy link
Collaborator

benjamn commented Jan 21, 2014

@DavidBruant did you want to take a swing at this, or would you mind if I go ahead and do it?

@DavidBruant
Copy link
Author

I don't mind at all :-)

@benjamn
Copy link
Collaborator

benjamn commented Jan 22, 2014

Published a new release to NPM including this fix: https://github.com/facebook/regenerator/releases/tag/v0.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants