Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sapling should interop with Turborepo #556

Closed
steveluscher opened this issue Mar 9, 2023 · 4 comments
Closed

Sapling should interop with Turborepo #556

steveluscher opened this issue Mar 9, 2023 · 4 comments

Comments

@steveluscher
Copy link
Contributor

steveluscher commented Mar 9, 2023

Turborepo is a build system that tracks dependencies using artifact hashes. It has a fast mode that relies on SCM information which, when using Sapling, it can't find.

I wonder if Sapling could provide some sort of reasonable ‘API compatibility’ with git by synthesizing just enough of the .git folder to be useful. That way tools that look for a .git folder would Just Work™ (see also #555).

Problem

> turbo run compile:docs compile:js compile:typedefs test:lint test:prettier test:typecheck test:unit:browser test:unit:node test:live-with-test-validator test:treeshakability:browser test:treeshakability:native test:treeshakability:node

 WARNING  cannot find a .git folder. Falling back to manual file hashing (which may be slower). If you are running this build in a pruned directory, you can ignore this message. Otherwise, please initialize a git repository in the root of your monorepo
@quark-zju
Copy link
Contributor

We don't provide a .git by design. You can find some discussions at #182.

@steveluscher
Copy link
Contributor Author

I realize that, but quitters like me who want nothing but to be able to use the Facebook/Mercurial workflow here on the outside will never be able to use Sapling unless there's an interop story with Jest/Turborepo/Codecov/etc.

@quark-zju
Copy link
Contributor

quark-zju commented Mar 10, 2023

I think the more practical approach is to add sapling support in jest and turborepo (not the other way around).

@steveluscher
Copy link
Contributor Author

Makes sense; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants