Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@stylexjs/valid-styles]: overflow: 'clip' not allowed #620

Closed
slightly-askew opened this issue Jun 27, 2024 · 1 comment · Fixed by #621
Closed

[@stylexjs/valid-styles]: overflow: 'clip' not allowed #620

slightly-askew opened this issue Jun 27, 2024 · 1 comment · Fixed by #621
Labels
bug Something isn't working

Comments

@slightly-askew
Copy link

Describe the issue

When I set the property {overflow: 'clip'} to an element, I receive an eslint error, but the style is valid and works as expected.
CleanShot 2024-06-28 at 08 21 48

It also creates Typescript errors as I pass the styles around to different elements

Expected behavior

No eslint error would be displayed by @stylexjs/valid-styles plugin

Steps to reproduce

install stylex 0.6.1 and @stylexjs/valid-styles plugin 0.6.1

create a dive element and set style to {overflow: 'clip'}

Test case

No response

Additional comments

No response

@slightly-askew slightly-askew added the bug Something isn't working label Jun 27, 2024
@necolas
Copy link
Contributor

necolas commented Jun 28, 2024

overflow:'clip' has relatively limited browser support compared to what we typically expect of web apps today at Meta.

It might make sense to keep the eslint warning if it can be suppressed inline, or if the value 'clip' can be allowed via eslint-plugin configuration. I don't think we want type checker errors in this case though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants