Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StrictMock method return type validation #150

Closed
fornellas opened this issue Apr 9, 2020 · 1 comment · Fixed by #153
Closed

Implement StrictMock method return type validation #150

fornellas opened this issue Apr 9, 2020 · 1 comment · Fixed by #153
Assignees
@fabriziocucci
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Type Checking

Comments

@fornellas
Copy link
Contributor

This feature is currently missing. This branch:
https://github.com/facebookincubator/TestSlide/pull/new/strict_mock_return_type_validation
has tests covering those cases.
@fornellas fornellas added this to the Type Checking milestone Apr 9, 2020
@fornellas fornellas added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 9, 2020
@fabriziocucci fabriziocucci self-assigned this Apr 9, 2020
@fornellas
Copy link
Contributor Author

Tip: there's a _validate_return_type function ready for that.

@fabriziocucci fabriziocucci mentioned this issue Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabriziocucci fabriziocucci

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
Type Checking
Development

Successfully merging a pull request may close this issue.

Strict mock return type validation facebook/TestSlide
2 participants
@fornellas @fabriziocucci