Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

before_once: add docs and failure test #61

Closed
fornellas opened this issue Oct 29, 2019 · 0 comments · Fixed by #65
Closed

before_once: add docs and failure test #61

fornellas opened this issue Oct 29, 2019 · 0 comments · Fixed by #65
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fornellas
Copy link
Contributor

before_once is not documented and has no test case covering failures. Both needs addressing.

When a before_once hook fails, the expectation is that all tests that depends on it should fail with the same signal. I believe currently, the first test will get the failure, but others will not run the hook, and execute as if the hook worked.
@fornellas fornellas added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 29, 2019
@fornellas fornellas mentioned this issue Oct 30, 2019
Merged
@fornellas fornellas added this to the TestSlide's DSL milestone Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop before_once facebook/TestSlide
1 participant
@fornellas