Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change for ruby lib. #142

Closed
tiegz opened this issue Jul 22, 2016 · 3 comments
Closed

Name change for ruby lib. #142

tiegz opened this issue Jul 22, 2016 · 3 comments

Comments

@tiegz
Copy link
Contributor

tiegz commented Jul 22, 2016

I'd like to propose changing the Ruby lib name from ThreatExchange to threat_exchange everywhere.

Snakecase is the most common convention in Ruby (e.g. list of gems on Rubygems).

It's mostly a cosmetic change, but could help adoption of the library.

@wxsBSD
Copy link
Contributor

wxsBSD commented Jul 22, 2016

This seems fine, but it may break existing scripts which use it. Do you have any sense for how many people this may break? I'm certainly not opposed to it but want to attempt to minimize breakage.

@tiegz
Copy link
Contributor Author

tiegz commented Jul 22, 2016

@wxsBSD the Ruby lib was a little stale until last week, so I bet it won't be too bad. We may even be able to keep an alias around for a bit. I'll try it out later and might PR this.

@wxsBSD
Copy link
Contributor

wxsBSD commented Aug 1, 2016

Awesome. I'll be closing this out and await a PR. :)

@wxsBSD wxsBSD closed this as completed Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants