Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom domain setting is not supported in ptp4u #219

Closed
leoleovich opened this issue Oct 25, 2022 · 0 comments · Fixed by #228
Closed

Custom domain setting is not supported in ptp4u #219

leoleovich opened this issue Oct 25, 2022 · 0 comments · Fixed by #228
Assignees
@cihangir

Comments

@leoleovich
Copy link
Contributor

It's hardcoded to 0 in
https://github.com/facebook/time/blob/main/ptp/ptp4u/server/subscription.go#L205
Need to patch NewSubscriptionClient to allow setting a custom domain.
@cihangir cihangir self-assigned this Oct 31, 2022
@leoleovich leoleovich linked a pull request Nov 11, 2022 that will close this issue
ptp/ptp4u: add default DomainNumber support #219 #228
Merged
vvfedorenko added a commit that referenced this issue Nov 11, 2022
@vvfedorenko
Merge pull request #228 from cihangir/domain_number
4b3e8f0 
ptp/ptp4u: add default DomainNumber support #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cihangir cihangir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ptp/ptp4u: add default DomainNumber support #219 cihangir/time
2 participants
@cihangir @leoleovich