Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated Websocket in Chrome/Chromium #385

Closed
minrk opened this issue Oct 19, 2011 · 1 comment
Closed

updated Websocket in Chrome/Chromium #385

minrk opened this issue Oct 19, 2011 · 1 comment

Comments

@minrk
Copy link
Contributor

minrk commented Oct 19, 2011

I run Chrome dev channel, which has updated its websocket version, breaking compatibility with tornado websockets.

ref: http://updates.html5rocks.com/2011/10/WebSockets-updated-to-latest-version-in-Chrome-Canary

Which suggests Sec-WebSocket-Version is now 13, but Wikipedia suggests Chromium is using something called hybi 17, which may or may not be the same.

I imagine you guys are more familiar with what these things actually mean than I am.
@dspiteself
Copy link

I made a pull request for a quickfix, but from what i can tell the ver 8 connection handler does not even support wss
#387

@minrk minrk mentioned this issue Jan 9, 2012
Closed
markvoorhies pushed a commit to markvoorhies/ipython that referenced this issue Dec 3, 2013
@fperez
Monkeypatch Tornado 2.1.1 so it works with Google Chrome 16.
113b26e 
We're just applying manually a fix from Tornado itself, see for
details:

tornadoweb/tornado#385
tornadoweb/tornado@84d7b458f956727c3b0d6710
@fperez fperez mentioned this issue Oct 30, 2011
Merged
@adamcik adamcik mentioned this issue Jul 28, 2014
Closed
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@fperez
Monkeypatch Tornado 2.1.1 so it works with Google Chrome 16.
8485b27 
We're just applying manually a fix from Tornado itself, see for
details:

tornadoweb/tornado#385
tornadoweb/tornado@84d7b458f956727c3b0d6710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dspiteself @minrk @bdarnell