Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install broken #39

Closed
dturner-tw opened this issue May 20, 2014 · 3 comments
Closed

make install broken #39

dturner-tw opened this issue May 20, 2014 · 3 comments

Comments

@dturner-tw
Copy link
Contributor

make install now seems to includes an extra /usr/local, so it tries to install to /usr/local/usr/local/....

This is the commit that breaks it, along with the line I believe to be at fault:
6ea4ed8#diff-c949f93d03f44a4217d7a138f9e2e54aR3

@wez
Copy link
Contributor

wez commented May 20, 2014

Doh, yeah, looks like the non-DESTDIR install case is broken. I'm leaning towards this as a fix:

$ git diff
diff --git a/Makefile.am b/Makefile.am
index b4b988e..7d6c8c2 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,6 +1,6 @@
 bin_PROGRAMS = watchman
 # ensure that we have a reasonable default for the python install
-DESTDIR ?= ${prefix}
+DESTDIR ?= /

 doc_DATA = README.markdown
 docdir = ${prefix}/share/doc/watchman-$(VERSION)

@dturner-tw
Copy link
Contributor Author

That solves the problem for me. Thanks.

wez added a commit that referenced this issue May 20, 2014
@wez
Copy link
Contributor

wez commented May 20, 2014

sorry, and thanks for the report!

@wez wez closed this as completed May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants