Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby tests failing #41

Closed
sunshowers opened this issue Jun 7, 2014 · 3 comments
Closed

ruby tests failing #41

sunshowers opened this issue Jun 7, 2014 · 3 comments

Comments

@sunshowers
Copy link
Contributor

I'm going to disable the ruby tests while someone figures out why they're failing.
@sunshowers
Copy link
Contributor Author

See https://travis-ci.org/facebook/watchman/jobs/27038433#L2173 for an example.

@wincent
Copy link
Contributor

wincent commented Jul 9, 2014

I believe this is caused by the move to RSpec 3.0; I believe we can fix this by specifying a desired RSpec version in the gemspec here:

https://github.com/facebook/watchman/blob/master/ruby/ruby-watchman/ruby-watchman.gemspec#L31

(We could also try to tweak the tests so that they pass in RSpec 2.x or 3.x, but that's going to be a game of whack-a-mole, possibly breaking whenever RSpec decides to make upstream changes.)

@wincent wincent mentioned this issue Jul 11, 2014
Closed
wez pushed a commit that referenced this issue Jul 16, 2014
@wincent @wez
Re-enable Ruby tests, pegging to RSpec 3.0
b3eb41e 
These started failing when RSpec 3.0 came out, so adapt the specs to
make the tests pass under RSpec 3.0, and peg the dependency to that
revision so that we don't have to fix this again in the future.

Note that we have to run `bundle install` manually because Travis will
only do it for us automatically if it detects a Gemfile in the root
level of the repo:

http://docs.travis-ci.com/user/languages/ruby/

Sample failure:

https://travis-ci.org/facebook/watchman/jobs/29939087

Additionally, ensure we never try a `bundle exec` without first
confirming that the `bundle` is present:

https://travis-ci.org/facebook/watchman/jobs/29939419

Fixes: #41
@wez
Copy link
Contributor

wez commented Aug 10, 2014

looks like we've finally beaten Travis into shape with running the ruby tests here too; closing out.
Thanks!

@wez wez closed this as completed Aug 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable Ruby tests, pegging to RSpec 2.x
3 participants
@wincent @wez @sunshowers