Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options template #49

Closed
ldemailly opened this issue Aug 12, 2015 · 1 comment
Closed

options template #49

ldemailly opened this issue Aug 12, 2015 · 1 comment

Comments

@ldemailly
Copy link
Contributor

We find that we would like different sets of options for say,

open source command line
library running as a daemon
fb internal settings
etc...

an example is when I changed the ipv6 to false so it works on ipv4 only machines - which is reasonable for the general release, I broke some facebook internal deployement because the default changed but we should have a way to name/have "sets" of options
@ldemailly
Copy link
Contributor Author

so it's not exactly extensible templates but it's a working solution:
fixed in 8cc5254

ldemailly referenced this issue Aug 26, 2015
@uddipta @ldemailly
Adding option templates to wdt
8cc5254 
Summary: Adding option templates to wdt. Right now, there is only flash and
disk. Depending on the option type, flags are initialized to different values.
Value of a specific option can be changed using flags. For disk, only number of
threads is changed and block mode is disabled.

Reviewed By: @ldemailly, @nikunjy

Differential Revision: D2363348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ldemailly