You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #124 broke the build using concurrent feature, by changing the scope of the fft_in_place function (originally in fft/serial module) to private, and moving it to the fft/fft_inputs module without updating the calls in the fft/concurrent module.
I think this already happened in the past that a change breaking builds with parallelization went unnoticed in the main branch, perhaps we should consider having a check in the CI?
The text was updated successfully, but these errors were encountered:
PR #124 broke the build using concurrent feature, by changing the scope of the
fft_in_place
function (originally infft/serial
module) to private, and moving it to thefft/fft_inputs
module without updating the calls in thefft/concurrent
module.I think this already happened in the past that a change breaking builds with parallelization went unnoticed in the main branch, perhaps we should consider having a check in the CI?
The text was updated successfully, but these errors were encountered: