Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with concurrent feature #131

Closed
Nashtare opened this issue Jan 18, 2023 · 0 comments · Fixed by #132
Closed

Build fails with concurrent feature #131

Nashtare opened this issue Jan 18, 2023 · 0 comments · Fixed by #132

Comments

@Nashtare
Copy link
Contributor

Nashtare commented Jan 18, 2023

PR #124 broke the build using concurrent feature, by changing the scope of the fft_in_place function (originally in fft/serial module) to private, and moving it to the fft/fft_inputs module without updating the calls in the fft/concurrent module.

I think this already happened in the past that a change breaking builds with parallelization went unnoticed in the main branch, perhaps we should consider having a check in the CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant