Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

->join() is gone #170

Closed
HRMsimon opened this issue Nov 1, 2016 · 1 comment · Fixed by #171
Closed

->join() is gone #170

HRMsimon opened this issue Nov 1, 2016 · 1 comment · Fixed by #171

Comments

@HRMsimon
Copy link

HRMsimon commented Nov 1, 2016

facebook/hhvm@80d0af7 kills ->getWaitHandle()->join(). Need to replace the two calls to it with \HH\Asio\join()

vendor/facebook/xhp-lib/src/core/Element.php:23:53,56: Could not find method join in an object of type WaitHandle (Typing[4053])
  /tmp/hh_server/hhi_1b7ab862/interfaces.hhi:831:36,45: This is why I think it is an object of type WaitHandle
  /tmp/hh_server/hhi_1b7ab862/classes.hhi:109:16,25: Declaration of WaitHandle is here
vendor/facebook/xhp-lib/src/core/Primitive.php:22:53,56: Could not find method join in an object of type WaitHandle (Typing[4053])
  /tmp/hh_server/hhi_1b7ab862/interfaces.hhi:831:36,45: This is why I think it is an object of type WaitHandle
  /tmp/hh_server/hhi_1b7ab862/classes.hhi:109:16,25: Declaration of WaitHandle is here
fredemmott added a commit to fredemmott/xhp-lib that referenced this issue Nov 7, 2016
@fredemmott
Remove getWaitHandle()->join()
71aa751 
replaced with HH\Asio\join()

fixes hhvm#170. Tested with 3.15 and nightly
@fredemmott fredemmott mentioned this issue Nov 7, 2016
Merged
@HRMsimon
Copy link
Author

HRMsimon commented Nov 7, 2016

New tag please :)

Changes that'll be included: 2.3.0...master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove getWaitHandle()->join() fredemmott/xhp-lib
1 participant
@HRMsimon