Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractNodes puts objects into slow mode #61

Closed
esprehn opened this issue Mar 26, 2015 · 1 comment · Fixed by #108
Closed

extractNodes puts objects into slow mode #61

esprehn opened this issue Mar 26, 2015 · 1 comment · Fixed by #108

Comments

@esprehn
Copy link

esprehn commented Mar 26, 2015

extractNodes calls delete on objects which puts them into slow mode in v8 and other JS engines. Specifically calling delete node.layout; and delete node.children; is bad.

It also adds a children property to the layout objects which means that the code inside the layout algorithm and the code outside are using two different "kinds" of objects in terms of what the JS engine thinks the types are.

It seems like if the layout algorithm wants to create a separate tree of objects it should do that during layout instead of trying to mutate the node tree after the layout. There's also no reason to try to "clean up" the children property if it's empty, just leave the empty arrays. It's better to make all the objects look consistent.

@vjeux
Copy link
Contributor

vjeux commented Jun 4, 2015

So sorry about the huge delay for responding to your issues, I somehow didn't see the emails with your issues. All your suggestions are very good! If you still care about this project, please send pull requests and i'll gladly accept them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants