New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack buffer overflow in v043 #94
Comments
Thanks for reporting @drach. I'll look into it. There is also a chance that the problem lies into |
I believe to have fixed this issue within latest update of "dev" branch 695a6cb. The issue was within Since the issue is not specific to your sample, I'm surprised it has not show up earlier within Continuous Integration tests, as If you witness some instability issues outside of |
Indeed,
Agree, will check it closer. |
I was wrong. We call |
Thanks for feedback @drach. Which reminds me : the decompression context is quite large currently, and it's part of my todo list to tame it. In the meantime, should you need to keep your stack at 128K per thread, I suggest creating a context per thread with |
VS2013 and Xcode711/Asan detect a stack buffer overflow in a released v0.4.3 with a specific input data.
How to repro
Use the following PVRTC4 compressed sample image with a
fullbench
app, called without additional parameters.https://www.dropbox.com/s/tlgr7lxpmtiq4yw/sample.pvr?dl=0
Output with VS2013-update5, Windows7:
Output with Xcode711, Clang700.1.76, enabled ASan, iOS9.1:
Possible consequences
In an existing quite a big iOS app the invocation of
ZSTD_decompress
(exactly this function, not its internals) may just crash after several dozens of successful calls, it looks like a problem in a corrupted stack. I didn't manage to localize a problem in a separated sample, only found an issue with a fullbench above. Still not totally sure whether both issues have the same root, but it may be.The text was updated successfully, but these errors were encountered: