-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
positivity constraint on season not respected #341
Comments
Checking the code, I don't see any obvious error or bug. I'll further run a hypothetical check without your data to reproduce this scenario first before I get back to you.. thanks for reporting it. |
Hey @drbenvincent |
Thanks for that link @laresbernardo. I'll work through that - it looks to touch on issues I've been thinking about. Just a bit more on the motivation... I'm trying to produce a contribution plot, as in a stacked area plot over time which decomposes the total predicted outcome variable over time into its various component parts. You could argue that (regardless of the implementation details) it would be appealing (and should be possible) to plot the contributions over time from each channel, intercept, trend, seasonality, etc. So I'm a little uncertain at the moment if there is a working positivity constraint or not? Either way, it should be possible to find the maths of the seasonality implementation (presumably in Prophet) that would allow generation of a contribution plot over time from the fitted parameters from Robyn. |
I observe the same issue. Robyn 3.6.3 |
Please reopen if this issue reoccurs. |
I am running a model with the following options
but when I examine
pareto_alldecomp_matrix.csv
(and just focus on a particular model of interest) then I see both positive and negative values. The positivity constraint does not seem to be applied.I'd be grateful if you could confirm that this is a bug. If it is, I'd be even more grateful if it could be fixed.
Environment & Robyn version
R version 4.0.4
Robyn version 3.6.1 (installed by
remotes::install_github('facebookexperimental/Robyn/R')
)The text was updated successfully, but these errors were encountered: