Adding set operations to TagPropagationSet

[JustusAdam]

Description

This adds two convenience functions for constructing taint propagation masks easier. E.g. adding and removing propagation types from existing masks

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• API change with a documentation update
• Additional test coverage
• Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

I added two test cases, one for each function that verifies the basic functionality

Checklist:

• Fork the repo and create your branch from main.
• If you've added code that should be tested, add tests.
• If you've changed APIs, update the documentation.
• Ensure the test suite passes.
• Make sure your code lints.
• If you haven't already, complete your CLA here: https://code.facebook.com/cla

[facebook-github-bot]

Hi @JustusAdam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[codecov]

Codecov Report

Merging #1154 (8521102) into main (4fe7492) will decrease coverage by 0%.
The diff coverage is 55%.

❗ Current head 8521102 differs from pull request most recent head 1c03e98. Consider uploading reports for the commit 1c03e98 to get more accurate results

@@          Coverage Diff           @@
##            main   #1154    +/-   ##
======================================
- Coverage     77%     76%    -1%     
======================================
  Files         23      23            
  Lines      16086   16198   +112     
======================================
- Hits       12499   12471    -28     
- Misses      3587    3727   +140     

Impacted Files	Coverage Δ
checker/src/constant_domain.rs	58% <ø> (+<1%)	⬆️
checker/src/expression.rs	64% <0%> (-6%)	⬇️
checker/src/path.rs	84% <37%> (-2%)	⬇️
checker/src/crate_visitor.rs	74% <54%> (+<1%)	⬆️
checker/src/body_visitor.rs	87% <63%> (-2%)	⬇️
checker/src/block_visitor.rs	81% <67%> (+2%)	⬆️
checker/src/call_visitor.rs	80% <68%> (-2%)	⬇️
checker/src/options.rs	78% <74%> (+<1%)	⬆️
checker/src/utils.rs	87% <80%> (+<1%)	⬆️
checker/src/type_visitor.rs	74% <85%> (-1%)	⬇️
... and 19 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[hermanventer]

We'll have to update crates.io before the mirai_on_mirai tests will pass. Can't do that until you sign the CLA. Don't wait too much with that since tomorrow is my last day at Meta and it may take a while before anyone else takes up the baton.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[JustusAdam]

@hermanventer Sorry i think I clicked the two buttons a little too close together. Should be all set now.

Thanks.

[hermanventer]

Please fix the test failures.

[hermanventer]

And I'm already locked out from writing to this repo. Let's see if anyone else steps in. If nothing happens for a week or so, I'll fork.

[JustusAdam]

it may take a while before anyone else takes up the baton

This is quite unfortunate. Is this project going to be retired?

[hermanventer]

I am going to maintain it actively, with or without Meta. For now, since no-one has let me know that they will merge pull requests to this repo, I'll maintain my own fork: https://github.com/hermanventer/MIRAI. If you move this PR to my fork, I'll be happy to merge it.