Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: robyn_write() requires both OutputCollect and OutputModels #724

Closed
DzimitryM opened this issue May 5, 2023 · 2 comments
Closed

Demo: robyn_write() requires both OutputCollect and OutputModels #724

DzimitryM opened this issue May 5, 2023 · 2 comments
Assignees
@gufengzhou
Labels
bug Something isn't working

Comments

@DzimitryM
Copy link

Since version 3.10.3.9000 the function robyn_write() requires both OutputCollect and OutputModels arguments.
demo.R needs to be updated accordingly, otherwise it returns

ExportedModel <- robyn_write(InputCollect, OutputCollect, select_model, export = create_files)
Error in OutputModels$convergence : 
  $ operator is invalid for atomic vectors

--
Robyn version 3.10.3.9000
@laresbernardo laresbernardo added the bug Something isn't working label May 5, 2023
@laresbernardo
Copy link
Collaborator

Hey @gufengzhou I noticed you changed something here. Would you mind checking this one? We probably don't need OutputModels given it's actually stored within OutputCollect.

gufengzhou added a commit that referenced this issue May 6, 2023
@gufengzhou
fix: robyn_write bug #724
5a2f5b1
@gufengzhou
Copy link
Contributor

Sorry my bad. Fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gufengzhou gufengzhou

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DzimitryM @gufengzhou @laresbernardo