-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holiday as dummy? #76
Comments
How many years of data do you have? Are you using trend, season and holiday from Prophet? In case of More than one Xmas included in the data (and there is repeating pattern of course), season from prophet should be able to capture that. If not, and in case you are expecting peaks in for example Dec.24-31, one idea might be manually adding all days Dec.24-31 into the holiday csv, so that this will be also captured by the holiday variable from prophet. |
@gufengzhou thank you! Apparently I needed to have the exact observed dates in the holidays file. Now the prophet holiday variable is capturing the peaks. |
Hi, first of all please check prophet's documentation for more customised ways of using holidays, for example using lower_windows and upper_windows in the holidays.csv to account for holiday periods. Regarding volumes in non-holiday weeks, it's actually just me linearly transformed the original holiday variable to positive to avoid potential difficulty in decomposition and interpretation later. The variance of holiday won't change by this transformation and the latitude will be adjusted by the beta coefficient anyway. |
Hi guys, even after including the holidays file you supplied, I am still having big underpredictions in xmas week (xmas peaks are quite noticeable).
I tried adding a dummy variable in xmas week in the baseline group of variables but the model drops it (coef=0).
What is the correct way to add a dummy variable? or, is there a way to make the prophet holiday capture these peaks?
Thanks very much,
F
The text was updated successfully, but these errors were encountered: