-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lsp jump to definition bad behavior #90
Comments
@cjhopman this one sounds odd to me, it's not really behaviour I've seen. Can you provide some more context? What kind of field are you triggering the jump-to-definition on? And does it just jump to the start of the file ( I've seen the latter behaviour mainly before I implemented correct |
I see this too with the bazel mode:
Jumping from the |
@stagnation Ah, interesting, thanks for the insight! In general I would say anything that uses dotted definitions ( |
In cases where you try to go-to-definition on a dotted identifier, e.g. `foo.bar.baz`, the LSP will try to find where `foo` is defined, and check if it's a `struct` definition with a property named `bar`, and jump to that. However, in cases where this location cannot be resolved, an `unwrap_or_default` would result in jumping to to the top of the file. Instead, in such cases, jump to the definition of the variable `foo` itself, which is better than jumping to the top of the file. Fixes facebook#90
Summary: In cases where you try to go-to-definition on a dotted identifier, e.g. `foo.bar.baz`, the LSP will try to find where `foo` is defined, and check if it's a `struct` definition with a property named `bar`, and jump to that. However, in cases where this location cannot be resolved, an `unwrap_or_default` would result in jumping to to the top of the file. Instead, in such cases, jump to the definition of the variable `foo` itself, which is better than jumping to the top of the file. Fixes #90 Pull Request resolved: #92 Reviewed By: JakobDegen Differential Revision: D48863997 Pulled By: ndmitchell fbshipit-source-id: 07015bd7484d0c2d5e74544a9a91fcfbbd76c046
often when doing jump-to-definition on a field, it just jumps me to the top of the current file. this is worse than doing nothing.
The text was updated successfully, but these errors were encountered: