Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrimRate tests throttles scale when capacity is specified #4

Open
jmazzie opened this issue May 11, 2021 · 0 comments
Open

TrimRate tests throttles scale when capacity is specified #4

jmazzie opened this issue May 11, 2021 · 0 comments

Comments

@jmazzie
Copy link

jmazzie commented May 11, 2021

I was running fiosynth and noticed that my performance while running the TrimRate tests were above the throttled limit based on the test suite configuration. I figured out that this was due to me specifying the capacity of the device using the -c flag. I've worked around the issue by not specifying the capacity, but believe the issue can be fixed in fiosynth.py, if this wasn't intended.

In the prepServers function the logic to check if a test scales by the factor could be moved up a level. This way it only uses a capacity factor if the test is supposed to scale with capacity. Currently it checks if you've specified a capacity first and if you do it always will scale any scalable variables in a test.

I would submit a PR myself, but cannot currently sign the contributor license due to company policy.

Proposed modification of code (lines 643 to 649 of fiosynth.py):

if (profile['scale_by_capacity'] != 'N'):
    if args.factor <= 0.0:
         dut.factor = getMultiplier(dut.capacity)
    else:
         dut.factor = args.factor
else:
    dut.factor = 1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant