Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of received signals #168

Merged
merged 7 commits into from
Apr 20, 2020
Merged

Better handling of received signals #168

merged 7 commits into from
Apr 20, 2020

Conversation

fornellas
Copy link
Contributor

Improve signal handling (specially ^C):

  • testslide does not spit stack trace for ^C.
  • util/run_silent_if_successful.py:
    • Forward received signals to subprocess and wait for it to terminate.
    • Handle file not found errors gracefully.
  • Add util/ to black, mypy & flake8.

Before:
image
After:
image

@fornellas fornellas added the enhancement New feature or request label Apr 19, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 19, 2020
@fornellas fornellas added this to the Improve Build milestone Apr 19, 2020
david-caro
david-caro approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@david-caro david-caro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The coverage report failed though, that should be checked out

@fornellas
Copy link
Contributor Author

Yep! It was missing util/* at .coveragerc, added!

@fornellas fornellas merged commit 117056d into master Apr 20, 2020
@fornellas fornellas deleted the handle_sigint branch April 20, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-caro david-caro david-caro approved these changes

@deathowl deathowl Awaiting requested review from deathowl

Assignees
No one assigned
Labels
Build CLA Signed Do not delete this pull request or issue due to inactivity. enhancement New feature or request
Projects
None yet
Milestone
Improve Build
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fornellas @david-caro @facebook-github-bot