Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inheritances #178

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix inheritances #178

merged 1 commit into from
Apr 21, 2020

Conversation

fornellas
Copy link
Contributor

BaseFormatter was depending on ColorFormatterMixin. I've moved this part of the code to SlowImportWarningMixin so things are clearer.

@fornellas fornellas added the bug Something isn't working label Apr 21, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 21, 2020
fabriziocucci
fabriziocucci approved these changes Apr 21, 2020
View reviewed changes
Copy link

@fabriziocucci fabriziocucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabriziocucci fabriziocucci merged commit e04f65c into master Apr 21, 2020
@fabriziocucci fabriziocucci deleted the fix_formatter branch April 21, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziocucci fabriziocucci fabriziocucci approved these changes

@david-caro david-caro Awaiting requested review from david-caro

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fornellas @fabriziocucci @facebook-github-bot