Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: use python3 for run_silent_if_successful #261

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

davide125
Copy link
Member

TestSlide requires Python 3, so might as well use it here too. This fixes the build on systems that don't have Python 2 installed as /usr/bin/python, such as modern Fedora and CentOS.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 28, 2020
@fornellas
Copy link
Contributor

Python 2 has been officially dead for almost 1 year now... though I understand some distros lag behind on this.

@davide125 TestSlide's official builds run against specific Python versions and I recently put #254 RFC up for start using tox, which should address Python version issues, though it may mean there's some rework on the Fedora package later on. What do you think?

Topic hijack... @deathowl suggestions on where to go with the build? It seems there's always some small issue here and there.. @fabriziocucci pitched poetry today, which sounds interesting.

@fornellas fornellas merged commit df1ded9 into facebook:master Oct 28, 2020
@michel-slm
Copy link

@fornellas using tox should not affect the Fedora package that much. Some Fedora internal tools (such as fedpkg) use tox to make sure they work across different Python environments too - https://pagure.io/fedpkg/tree/master

As long as python setup.py build / install / test or some equivalent works fine without using venv then building in Fedora should be fine (builds are done in mock in a throwaway environment, and there is only one default system Python version per release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants