Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint check for incorrect propTypes usage #3840

Closed
gaearon opened this issue Jan 17, 2018 · 3 comments
Closed

Add ESLint check for incorrect propTypes usage #3840

gaearon opened this issue Jan 17, 2018 · 3 comments
Labels
tag: enhancement tag: underlying tools
Milestone
2.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2018

See #3818 (comment).
This depends on jsx-eslint/eslint-plugin-react#1647 getting resolved.
@gaearon gaearon added this to the 2.0.0 milestone Jan 17, 2018
@iansu
Copy link
Contributor

iansu commented Jan 17, 2018

I'm following up on the eslint-plugin-react issue and can fix this when that's done.

@iansu
Copy link
Contributor

iansu commented Jan 23, 2018

I've submitted a PR to eslint-plugin-react to add the functionality we need: jsx-eslint/eslint-plugin-react#1655.

@iansu
Copy link
Contributor

iansu commented Jan 29, 2018

My PR to eslint-plugin-react has been merged. I'm just waiting for it to be released and then I'll add this to create-react-app.

iansu added a commit to iansu/create-react-app that referenced this issue Feb 20, 2018
@iansu
Add ESLint check for incorrect propTypes usage (facebook#3840)
b0a96c9
@iansu iansu mentioned this issue Feb 20, 2018
Merged
iansu added a commit that referenced this issue Mar 25, 2018
@iansu
Add ESLint check for incorrect propTypes usage (#3840) (#4048)
8a34b7c
@renovate renovate bot mentioned this issue Apr 9, 2018
Merged
zmitry pushed a commit to zmitry/create-react-app that referenced this issue Sep 30, 2018
@iansu
Add ESLint check for incorrect propTypes usage (facebook#3840) (faceb…
037355c 
…ook#4048)
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tag: enhancement tag: underlying tools
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@iansu @gaearon