Create git repository with initial commit #1288

mauricedb · 2016-12-18T16:59:13Z

The intended test plan was:

Create a new React application on a machine with no Git installed. The application should be created with no additional artifacts just like before.
Create a new React application in a folder that is not part of a git repository. The application should be created with an additional new git repository. The initial application source files should be committed to the git repository as the initial commit.
Create a new React application in a folder that is already part of an existing git repository. The application should be created with no additional artifacts just like before.

However because I am running Windows natively I was unable to test this the way I wanted because the cra.sh doesn't run. Trying to do so in a Docker based Linux container was also less than successful.

facebook-github-bot · 2016-12-18T16:59:20Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot · 2016-12-18T17:03:35Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mauricedb · 2016-12-29T10:10:46Z

Added the docs to the readme.

mauricedb · 2017-02-08T10:32:27Z

@gaearon, Just wondering about this PR. It's been done for quite a while now. Thanks

gaearon · 2017-02-08T17:43:14Z

packages/react-scripts/scripts/init.js

+
+    execSync('git init', {stdio: 'ignore'});
+    execSync('git add .', {stdio: 'ignore'});
+    execSync('git commit -m "chore: initial commit from create-react-app"', {stdio: 'ignore'});


Can we just make this Initial commit? I don't think a lot of people are familiar with what "chore" means in this context, and many don't use this format.

gaearon · 2017-02-08T17:43:32Z

packages/react-scripts/scripts/init.js

+  try {
+    execSync('git --version', {stdio: 'ignore'});
+
+    if (insideGitRepository()) {


We should also bail if we're inside a Mercurial repository.

gaearon · 2017-02-08T17:44:37Z

Sorry I haven't been very responsive. Lots of work on React 😛
I left a few notes.

mauricedb · 2017-02-09T10:17:44Z

@gaearon, No problem, keep up the good work. Just making sure it doesn't get lost.

Made both the requested changes and rebased my commits on master.

gaearon · 2017-02-11T00:00:36Z

packages/react-scripts/template/README.md

@@ -1009,6 +1010,12 @@ Learn more about React Storybook:

 You can turn your React app into a [Progressive Web App](https://developers.google.com/web/progressive-web-apps/) by following the steps in [this repository](https://github.com/jeffposnick/create-react-pwa).

+## Git Repository


To be honest I think it's fine if don't specifically document this. I appreciate that you took the time to write it down but I don't think it's strictly necessary.

@gaearon Not quite sure what you want me to do. Do you want me to leave it as it is there already or delete it?

Yea let's just remove it.

OK, give me a minute.

gaearon · 2017-02-11T00:02:06Z

packages/react-scripts/scripts/init.js

@@ -64,6 +101,10 @@ module.exports = function(appPath, appName, verbose, originalDirectory, template
    }
  });

+  if (gitInit()) {


If we init git here, doesn't this mean adding react and react-dom dependencies are not added yet?

Good catch and a rather stupid mistake of me. Moved it to execute after adding react an and react-dom.

mauricedb · 2017-02-24T08:48:52Z

@gaearon Just checking if there any more changes you would like to see on this?

I see there are some conflicts now. Will rebase and resolve those later today.

Thanks

Timer · 2017-02-24T15:46:51Z

I think there was a bad merge, there's some unnecessary diffs that revert code from master.

mauricedb · 2017-02-26T13:25:33Z

@Timer I redid and fixed the rebase issues. I guess when Git said there where merge issues it really meant it this time :-(. Took a bit of time to figure out what went wrong but now I am only seeing my changes in the PR so the PR should be good.

However I am seeing the two TEST_SUITE=kitchensink tests fail on Travis when cleaning up. It is when removing the test-kitchensink directory. Not seeing why this is happening.

gaearon · 2017-05-16T00:17:43Z

Appreciate your work.
We're a bit short on time so I'm pushing this back to 0.11, but we'll look into it again at some point!

mauricedb · 2017-05-16T05:41:42Z

☺️

…

On Tue, May 16, 2017, 02:18 Dan Abramov ***@***.***> wrote: Appreciate your work. We're a bit short on time so I'm pushing this back to 0.11, but we'll look into it again at some point! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADDLIpOPepuAKx0vnjkdFJapiRerbNeyks5r6Os6gaJpZM4LQLML> .

gaearon · 2018-01-15T18:18:19Z

We'll need to come back to this before cutting 2.0, in part because I now see this in a newly created project:

mauricedb · 2018-01-16T11:08:48Z

@gaearon, Added two git commit statements to the tests that failed because of uncommitted changes. Still seeing the tests fail with a TypeError: Cannot read property 'loose' of undefined error that seems to be caused by babel-plugin-transform-destructuring not checking if options is an object.

gaearon · 2018-01-16T18:44:50Z

Sorry, our CI had a bad day.

old

mauricedb · 2018-01-18T05:49:07Z

@gaearon Seems TravisCI was having a bad CI day as well. If you restart the CI there, I don't have permissions to do so myself, it should turn green just like on AppVeyor.

bardiarastin · 2018-01-18T21:00:49Z

packages/react-scripts/scripts/init.js

@@ -134,6 +171,10 @@ module.exports = function(
    }
  }

+  if (gitInit()) {
+    console.log('Initializing git repository');


this is done after git initialized so i guess it's better to say git repository initialized rather than initializing

sendilkumarn · 2018-01-18T21:09:11Z

packages/react-scripts/scripts/init.js

@@ -104,7 +141,7 @@ module.exports = function(
    args = ['install', '--save', verbose && '--verbose'].filter(e => e);
  }
  args.push('react', 'react-dom');
-
+  


nit: can remove the space

sendilkumarn · 2018-01-18T21:09:13Z

packages/react-scripts/scripts/init.js

+    }
+
+    execSync('git init', {stdio: 'ignore'});
+    execSync('git add .', {stdio: 'ignore'});


Can this be git add -A?
(infact git add . covers create and update but this one feels more inclusive)

@sendilkumarn Sure, no problem but there really is no difference. Using git add -A is the same as git add . with Git 2. With Git 1 it isn't the same but the difference is in deleted files. As this is a newly created repo there is not going to be any deleted files.

gaearon · 2018-01-19T13:12:38Z

Thanks!

mauricedb · 2018-01-19T13:29:09Z

👍 Happy we finally got this merged in. Hope I can do more in the future.

* Create git repo with initial commit * Fixe commit message * Added the git repo to the docs * Bail if we are in a mercurial repository * Removed Chore from commit mesage * Create repo after installing react and react-dom * Removed docs * Commit changes when ejecting * Update after review * git add -A instead of git add . after code review

facebook-github-bot added the CLA Signed label Dec 18, 2016

gaearon previously requested changes Feb 8, 2017

View reviewed changes

mauricedb force-pushed the git-init branch from 03e52a9 to 0d90802 Compare February 9, 2017 10:15

gaearon reviewed Feb 11, 2017

View reviewed changes

mauricedb force-pushed the git-init branch from 6aedd39 to 7d59008 Compare February 24, 2017 11:48

gaearon added this to the 0.10.0 milestone Feb 24, 2017

mauricedb force-pushed the git-init branch 5 times, most recently from 7447e25 to 21f0c51 Compare February 26, 2017 11:58

mauricedb added 7 commits February 27, 2017 09:26

Create git repo with initial commit

03435a2

Fixe commit message

ec1fe18

Added the git repo to the docs

a721762

Bail if we are in a mercurial repository

66fdb9a

Removed Chore from commit mesage

f725934

Create repo after installing react and react-dom

e61343f

Removed docs

05367bc

mauricedb force-pushed the git-init branch from 21f0c51 to 05367bc Compare February 27, 2017 08:27

gaearon added this to the 0.11.0 milestone May 16, 2017

gaearon removed this from the 0.10.0 milestone May 16, 2017

jouderianjr mentioned this pull request Oct 11, 2017

Add git init and precommit hook for eslint ifactory-solutions/awesome-react-app#47

Merged

gaearon changed the base branch from master to next January 15, 2018 18:18

Merge branch 'next' into git-init

b9cfee9

mauricedb force-pushed the git-init branch 2 times, most recently from ff91fbf to a3aea49 Compare January 16, 2018 10:17

Commit changes when ejecting

ff65875

mauricedb force-pushed the git-init branch 2 times, most recently from b7aaa1e to ff65875 Compare January 16, 2018 11:01

mauricedb force-pushed the git-init branch from 6a90fc4 to ff65875 Compare January 17, 2018 19:41

bardiarastin suggested changes Jan 18, 2018

View reviewed changes

sendilkumarn reviewed Jan 18, 2018

View reviewed changes

mauricedb added 2 commits January 19, 2018 08:40

Update after review

7f15e12

git add -A instead of git add . after code review

bbd5c9a

gaearon added the tag: new feature label Jan 19, 2018

gaearon merged commit 247e5c9 into facebook:next Jan 19, 2018

ryancogswell mentioned this pull request Oct 4, 2018

No documentation about git init #5291

Closed

lock bot locked and limited conversation to collaborators Jan 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create git repository with initial commit #1288

Create git repository with initial commit #1288

mauricedb commented Dec 18, 2016

facebook-github-bot commented Dec 18, 2016

facebook-github-bot commented Dec 18, 2016

mauricedb commented Dec 29, 2016

mauricedb commented Feb 8, 2017

gaearon Feb 8, 2017

gaearon Feb 8, 2017

gaearon commented Feb 8, 2017

mauricedb commented Feb 9, 2017

gaearon Feb 11, 2017

mauricedb Feb 12, 2017

gaearon Feb 12, 2017

mauricedb Feb 12, 2017

gaearon Feb 11, 2017

mauricedb Feb 12, 2017

mauricedb commented Feb 24, 2017 •

edited

Loading

Timer commented Feb 24, 2017

mauricedb commented Feb 26, 2017

gaearon commented May 16, 2017

mauricedb commented May 16, 2017 via email

gaearon commented Jan 15, 2018

mauricedb commented Jan 16, 2018

gaearon commented Jan 16, 2018

mauricedb commented Jan 18, 2018

bardiarastin Jan 18, 2018

mauricedb Jan 19, 2018

sendilkumarn Jan 18, 2018

mauricedb Jan 19, 2018

sendilkumarn Jan 18, 2018

mauricedb Jan 19, 2018

gaearon commented Jan 19, 2018

mauricedb commented Jan 19, 2018

		@@ -1009,6 +1010,12 @@ Learn more about React Storybook:

		You can turn your React app into a [Progressive Web App](https://developers.google.com/web/progressive-web-apps/) by following the steps in [this repository](https://github.com/jeffposnick/create-react-pwa).

		## Git Repository

Create git repository with initial commit #1288

Create git repository with initial commit #1288

Conversation

mauricedb commented Dec 18, 2016

facebook-github-bot commented Dec 18, 2016

facebook-github-bot commented Dec 18, 2016

mauricedb commented Dec 29, 2016

mauricedb commented Feb 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon commented Feb 8, 2017

mauricedb commented Feb 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mauricedb commented Feb 24, 2017 • edited Loading

Timer commented Feb 24, 2017

mauricedb commented Feb 26, 2017

gaearon commented May 16, 2017

mauricedb commented May 16, 2017 via email

gaearon commented Jan 15, 2018

mauricedb commented Jan 16, 2018

gaearon commented Jan 16, 2018

mauricedb commented Jan 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon commented Jan 19, 2018

mauricedb commented Jan 19, 2018

mauricedb commented Feb 24, 2017 •

edited

Loading