-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document configuration and build process #362
Conversation
131b25b
to
3246059
Compare
Ace. |
8717c0f
to
6c47426
Compare
Great idea Dan. Yes please! |
c321146
to
a43fc43
Compare
require.resolve('babel-plugin-transform-object-rest-spread'), | ||
require.resolve('babel-plugin-transform-react-constant-elements'), | ||
// function* () { yield 42; yield 43; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaearon what is this for? (just curious 💭 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm it's an example of regenerator
I think this would be really a helpful point of reference for students. |
require.resolve('babel-plugin-transform-object-rest-spread'), | ||
require.resolve('babel-plugin-transform-react-constant-elements'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the only non-comment change in this PR, is it intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I just moved it a few lines down for consistency with dev config (order shouldn’t matter for this transform).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i didn't see it, nevermind then 👍
…react-app * 'master' of https://github.com/facebookincubator/create-react-app: 0.3.0-alpha Update some deps Document configuration and build process (facebook#362) # Conflicts: # config/webpack.config.dev.js
This seems like a nice thing to do since the user will have to deal with this after ejection.
Also serves as a good reminder for us in the future for why we made certain choices.