Send proper error response upon proxy error #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks! |
cloudmu
changed the title
stayradiated
pushed a commit
to stayradiated/create-react-app
that referenced
this pull request
Sep 7, 2016
…dleware. (facebook#588) * Change http-proxy-middleware logLevel from silent to error * provide onError handler for httpProxyMiddleware * Send proper error reponse upon proxy error.
cloudmu
changed the title
Merged
|
This should be fixed in 0.4.2. |
|
Yes, works as expected. |
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
…dleware. (facebook#588) * Change http-proxy-middleware logLevel from silent to error * provide onError handler for httpProxyMiddleware * Send proper error reponse upon proxy error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the custom onError handler for httpProxyMiddleware only logs proxy error on the console (#502). This amends the onError handler so it will also send proper error response to the client.
Otherwise the client will wait for the response and eventually timeout with ERR_EMPTY_RESPONSE, instead of the proper proxy error. See two screenshots before/after this PR.
No proper error response (timeout after up to 2 min):
Proper error response (with this PR):
Note the error response to the client also mirrors the error logged on the dev console:
Proxy error: Could not proxy request /api/login from localhost:3000 to http://localhost:3001 (ECONNREFUSED).