Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load setupTests file at setupTestFramework stage #846

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Load setupTests file at setupTestFramework stage #846

merged 1 commit into from
Oct 5, 2016

Conversation

just-boris
Copy link
Contributor

@just-boris just-boris commented Oct 4, 2016

fixes #824

  • setupFiles now contains only polyfills
  • if src/setupTests.js file exists, it will be called after test framework initialization

@gaearon gaearon added this to the 0.7.0 milestone Oct 5, 2016
@gaearon gaearon merged commit 15c20f1 into facebook:master Oct 5, 2016
@gaearon
Copy link
Contributor

gaearon commented Oct 5, 2016

Thanks!

@just-boris just-boris deleted the setup-test-framework branch October 5, 2016 12:01
kitze added a commit to kitze/custom-react-scripts that referenced this pull request Oct 6, 2016
…react-app

# By Dan Abramov (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  Correct a comment mistype in webpack production config (facebook#855)
  load setupTests file at setupTestFramework stage (facebook#846)
  Spell check (facebook#845)
  Tweak readme
  Update instructions on publishing to GitHub pages (facebook#841)
  Make webpackHotDevClient support webpack 2 too (facebook#840)
  Tweak eject output
  Promote "React must be in scope" to be an error (facebook#822)
  Fix script name to open chrome (facebook#831)
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this pull request Mar 7, 2018
…react-app

# By Dan Abramov (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  Correct a comment mistype in webpack production config (facebook#855)
  load setupTests file at setupTestFramework stage (facebook#846)
  Spell check (facebook#845)
  Tweak readme
  Update instructions on publishing to GitHub pages (facebook#841)
  Make webpackHotDevClient support webpack 2 too (facebook#840)
  Tweak eject output
  Promote "React must be in scope" to be an error (facebook#822)
  Fix script name to open chrome (facebook#831)
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setupTestFrameworkScriptFile option is missing
3 participants