Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--extensions can't be used to match files with no extension, like BUCK or Makefile #2

Closed
swolchok opened this issue Apr 19, 2018 · 3 comments
Closed

--extensions can't be used to match files with no extension, like BUCK or Makefile #2

swolchok opened this issue Apr 19, 2018 · 3 comments

Comments

@swolchok
Copy link
Contributor

The solution to this is probably to support -g/--glob like ripgrep, since we use the ignore crate to implement --extensions anyway and we could just implement -g with passthrough to ignore.
@swolchok swolchok changed the title --extensions can't be used to match files with no extension, like BUCK --extensions can't be used to match files with no extension, like BUCK or Makefile Apr 19, 2018
@swolchok
Copy link
Contributor Author

While we're at it, we might as well support --iglob too.

@gsquire
Copy link
Contributor

gsquire commented Apr 25, 2018

I can take a shot at this. Reading some of the ripgrep documentation I see that globs take precedence over other matching logic. So if the user opts for glob or iglob, it would be used instead of extensions. Do you want to copy this behavior for fastmod?

@swolchok
Copy link
Contributor Author

Sounds great to me! It would probably be best to state that each of glob and iglob conflicts_with extensions.

@gsquire gsquire mentioned this issue Apr 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swolchok @gsquire