Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Node API #7

Closed
samskivert opened this issue Oct 19, 2017 · 1 comment
Closed

Improve Node API #7

samskivert opened this issue Oct 19, 2017 · 1 comment

Comments

@samskivert
Copy link
Contributor

The Node API is currently admirably simple, but with a tiny bit of effort it could achieve greater flexibility while retaining its simplicity. Let's:

  • Modify the scripts to pass their own command line args through to the tool.
  • Modify the scripts to not assume the target file suffix is .glb.
  • Name the exported function convert instead of fbx2glb, since we're not going to assume a GLB is being generated.
  • Allow args to be supplied to the tool via the exported convert function.
@zellski
Copy link
Contributor

zellski commented Oct 19, 2017

Fixed in #11.

@zellski zellski closed this as completed Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samskivert @zellski