-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation error on OS X #22
Comments
will take a look |
What version of boost are you using? |
Boost version is 1.68 (which comes with brew) |
Any updates on this? I saw some mac related commits and tried the mac-build.sh script again today, but the error remains. |
I just gave it a spin on my machine (macOS 10.14.2 with Boost 1.69) and it built fine. Are you still seeing errors? |
From the look of the error above, it seems that folly may have been misconfigured (as the error is due to using a linux-specific memory API). There ought to be a compatibility setting defined during the folly configuration that makes it not use that. Can you post the full output of your build, including the folly cmake configuration part? |
Compiling fizz using the mac build script on Mojave throws various errors:
`[ 6%] Building CXX object CMakeFiles/fizz.dir/server/ServerProtocol.cpp.o
/Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:208:16: warning:
'onError' is deprecated: onError loses the attached executor and is weakly
typed. Please move to thenError instead. [-Wdeprecated-declarations]
.onError([&state](folly::exception_wrapper ew) {
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/futures/Future.h:1517:3: note:
'onError' has been explicitly marked deprecated here
onError(F&& func) &&;
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:208:16: warning:
'onError<(lambda at
/Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:208:24)>'
is deprecated: onError loses the attached executor and is weakly typed.
Please move to thenError instead. [-Wdeprecated-declarations]
.onError([&state](folly::exception_wrapper ew) {
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/futures/Future.h:1511:5: note:
'onError<(lambda at
/Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:208:24)>'
has been explicitly marked deprecated here
[[deprecated(
^
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:9:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.h:17:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/Actions.h:12:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/protocol/Actions.h:17:
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/small_vector.h:739:14: error:
use of undeclared identifier 'malloc_usable_size'
return malloc_usable_size(u.pdata_.heap_) / sizeof(value_type);
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/small_vector.h:755:9: note:
in instantiation of member function
'folly::small_vector<boost::variant<fizz::DeliverAppData,
fizz::WriteToSocket, fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>, 4, void, void, void>::capacity' requested here
if (capacity() == size()) {
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/protocol/Actions.h:97:8: note:
in instantiation of function template specialization
'folly::small_vector<boost::variant<fizz::DeliverAppData,
fizz::WriteToSocket, fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>, 4, void, void,
void>::emplace_backfizz::WaitForData' requested here
acts.emplace_back(std::forward(thisAct));
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/server/Actions.h:61:17: note:
in instantiation of function template specialization
'fizz::detail::addAction<folly::small_vector<boost::variant<fizz::DeliverAppData,
fizz::WriteToSocket, fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>, 4, void, void, void>, fizz::WaitForData>'
requested here
fizz::detail::addAction(acts, std::forward(act)...);
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:157:14: note:
in instantiation of function template specialization
'fizz::server::detail::actionsfizz::WaitForData' requested here
return actions(WaitForData());
^
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:9:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.h:17:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/Actions.h:12:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/protocol/Actions.h:17:
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/small_vector.h:739:14: error:
use of undeclared identifier 'malloc_usable_size'
return malloc_usable_size(u.pdata_.heap_) / sizeof(value_type);
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/small_vector.h:599:33: note:
in instantiation of member function 'folly::small_vector<fizz::TLSContent,
4, void, void, void>::capacity' requested here
auto thisCapacity = this->capacity();
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/small_vector.h:519:7: note:
in instantiation of member function 'folly::small_vector<fizz::TLSContent,
4, void, void, void>::swap' requested here
swap(o);
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/protocol/Actions.h:39:8: note:
in instantiation of member function 'folly::small_vector<fizz::TLSContent,
4, void, void, void>::operator=' requested here
struct WriteToSocket {
^
/usr/local/include/boost/move/adl_move_swap.hpp:191:4: note: in instantiation of
function template specialization 'std::__1::swapfizz::WriteToSocket'
requested here
swap(x, y);
^
/usr/local/include/boost/move/adl_move_swap.hpp:227:27: note: in instantiation
of function template specialization
'boost_move_adl_swap::swap_proxyfizz::WriteToSocket' requested here
::boost_move_adl_swap::swap_proxy(x, y);
^
/usr/local/include/boost/variant/detail/move.hpp:45:14: note: (skipping 9
contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
::boost::adl_move_swap(lhs, rhs);
^
/usr/local/include/boost/variant/variant.hpp:2300:19: note: in instantiation of
function template specialization 'boost::variant<fizz::DeliverAppData,
fizz::WriteToSocket, fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>::apply_visitor<boost::detail::variant::swap_with<boost::variant<fizz::DeliverAppData,
fizz::WriteToSocket, fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable> > >' requested here
this->apply_visitor(visitor);
^
/usr/local/include/boost/variant/variant.hpp:2572:9: note: in instantiation of
member function 'boost::variant<fizz::DeliverAppData, fizz::WriteToSocket,
fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>::swap' requested here
lhs.swap(rhs);
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/small_vector.h:617:9: note:
in instantiation of function template specialization
'boost::swap<fizz::DeliverAppData, fizz::WriteToSocket,
fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>' requested here
swap(oldSmall[i], oldLarge[i]);
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/out/deps/include/folly/small_vector.h:468:7: note:
in instantiation of member function
'folly::small_vector<boost::variant<fizz::DeliverAppData,
fizz::WriteToSocket, fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>, 4, void, void, void>::swap' requested here
swap(o);
^
/Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:187:10: note:
in instantiation of member function
'folly::small_vector<boost::variant<fizz::DeliverAppData,
fizz::WriteToSocket, fizz::server::ReportHandshakeSuccess,
fizz::server::ReportEarlyHandshakeSuccess, fizz::ReportError,
fizz::EndOfData, folly::Function<void (fizz::server::State &)>,
fizz::WaitForData, fizz::server::AttemptVersionFallback,
fizz::SecretAvailable>, 4, void, void, void>::small_vector' requested here
return detail::handleAppClose(state);
^
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.cpp:9:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/ServerProtocol.h:17:
In file included from /Users/ben/dev/proxygen_mojave/fizz/fizz/server/Actions.h:12:
/Users/ben/dev/proxygen_mojave/fizz/fizz/protocol/Actions.h:97:8: error:
no matching member function for call to 'emplace_back'
acts.emplace_back(std::forward(thisAct));
The text was updated successfully, but these errors were encountered: