Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression in 2023.06.12.00] libfizz.so.1.0.0: undefined reference to softaes_block_encrypt #92

Closed
yurivict opened this issue Jun 17, 2023 · 2 comments

Comments

@yurivict
Copy link

proxygen fails to build because of the mising symbol in libfizz.so:

ld: error: /usr/local/lib/libfizz.so.1.0.0: undefined reference to softaes_block_encrypt [--no-allow-shlib-undefined]

See facebook/proxygen#450

FreeBSD 13.2

@yurivict
Copy link
Author

This patch fixes it:

--- CMakeLists.txt.orig 2023-06-17 04:33:21 UTC
+++ CMakeLists.txt
@@ -233,6 +233,7 @@ set(FIZZ_SOURCES
   third-party/libsodium-aegis/aegis256/aesni/aead_aegis256_aesni.c
   third-party/libsodium-aegis/aegis256/armcrypto/aead_aegis256_armcrypto.c
   third-party/libsodium-aegis/aegis256/soft/aead_aegis256_soft.c
+  third-party/libsodium-aegis/private/softaes.c
 )
 
 add_library(fizz

@NickR23
Copy link
Contributor

NickR23 commented Jun 20, 2023

Hey yurivict,

Thanks for bringing this to our attention. The fix has been committed: 0dc415e

@NickR23 NickR23 closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants