Removing 'fb' as the default 'prettier' config to enable use for all …

…users

Summary:
Problem:
- We were enforcing the Prettier config to be the fb (Facebook) values for all users (problem and solution described here D15122200)

Fix:
- Remove 'fb' as the default prettier config and set it in the module specific .eslintrc file

Reviewed By: rckclmbr

Differential Revision: D17116973

fbshipit-source-id: ee986b8711480b551580dddf51e689dba2d44e5d

nms/.eslintrc.js

@@ -13,6 +13,12 @@ const openSourcePattern = /\*\n \* Copyright 20\d{2}-present Facebook\. All Righ
 
 module.exports.extends = ['eslint-config-fbcnms'];
 module.exports.overrides = [
+  {
+    files: ['*'],
+    rules: {
+      'prettier/prettier': [2, 'fb', '@format'],
+    },
+  },
   {
     files: ['.eslintrc.js'],
     rules: {

nms/fbcnms-packages/eslint-config-fbcnms/README.md

@@ -4,18 +4,18 @@ This package provides Facebook NMS' eslint config as an extensible shared config
 
 ## Usage
 
-Our default export contains all of our ESLint rules, including ECMAScript 6+ and React. It requires `eslint`, `eslint-plugin-relay`, `eslint-plugin-header`, `eslint-plugin-import`, `eslint-plugin-node`, `eslint-plugin-lint`, `eslint-plugin-sort-imports-es6-autofix`.
+Our default export contains all of our ESLint rules, including ECMAScript 6+ and React. It requires `eslint`, `eslint-plugin-relay`, `eslint-plugin-header`, `eslint-plugin-import`, `eslint-plugin-node`, `eslint-plugin-lint`, `eslint-plugin-sort-imports-es6-autofix`, `eslint-config-fb-strict`.
 
 To install:
 
 Yarn
 ```
-yarn add eslint-config-fbcnms eslint-plugin-relay eslint-plugin-header eslint-plugin-import eslint-plugin-node eslint-plugin-lint eslint-plugin-sort-imports-es6-autofix --dev
+yarn add eslint-config-fbcnms eslint-config-fb-strict eslint-plugin-relay eslint-plugin-header eslint-plugin-import eslint-plugin-node eslint-plugin-lint eslint-plugin-sort-imports-es6-autofix --dev
 ```
 
 npm
 ```
-npm install --save-dev eslint-config-fbcnms eslint-plugin-relay eslint-plugin-header eslint-plugin-import eslint-plugin-node eslint-plugin-lint eslint-plugin-sort-imports-es6-autofix
+npm install --save-dev eslint-config-fbcnms eslint-config-fb-strict eslint-plugin-relay eslint-plugin-header eslint-plugin-import eslint-plugin-node eslint-plugin-lint eslint-plugin-sort-imports-es6-autofix
 ```
 
 - Add "extends": "eslint-config-fbcnms" to your .eslintrc

nms/fbcnms-packages/eslint-config-fbcnms/index.js

@@ -134,7 +134,7 @@ module.exports = Object.assign({}, fbStrict, {
 
     // Prettier Plugin
     // https://github.com/prettier/eslint-plugin-prettier
-    'prettier/prettier': [2, 'fb', '@format'],
+    'prettier/prettier': 2,
 
     // React Plugin
     // https://github.com/yannickcr/eslint-plugin-react