Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programmatically create test fixtures instead of checking in test files #12

Closed
danobi opened this issue Aug 14, 2018 · 1 comment
Closed

Programmatically create test fixtures instead of checking in test files #12

danobi opened this issue Aug 14, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@danobi
Copy link
Contributor

danobi commented Aug 14, 2018

Every test currently shares oomd/fixtures/cgroup. This is way too much coupling. There should be a TestUtil library (or similar) that abstracts this file creation away until run time.
@danobi danobi added the help wanted Extra attention is needed label Aug 14, 2018
@danobi
Copy link
Contributor Author

danobi commented Sep 28, 2018

I actually think checking in fixture files is ok. What I don't think is ok is all the tests sharing one fixture directory. Fortunately, oomd2 tests create separate directories.

@danobi danobi closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danobi