Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code of fixing bounding box missing #260

Closed
ShahryarSaljoughi opened this issue Jan 7, 2024 · 2 comments
Closed

Source code of fixing bounding box missing #260

ShahryarSaljoughi opened this issue Jan 7, 2024 · 2 comments

Comments

@ShahryarSaljoughi
Copy link
Contributor

Hi,

Hope you all are doing well.

In the demo, I noticed that I can fix the bounding box originally detected by the model, but the fixer_app does not include such functionality. In fixer_app, I can fix the detected joints via an appealing UI; however, the same functionality is not provided for fixing the bounding box.

Though this is not part of the core animating project, it would be good to have that feature within the repository too.

I would be glad to develop this part and have it merged into the repo if the maintainers consider it necessary.

@hjessmith
Copy link
Contributor

Hello @ShahryarSaljoughi

Thanks for offering to improve the repo in this manner. Extending the annotation fixing tool to include bounding box edits would indeed be useful and I would merge such a PR into main. Do note that changes to the bounding box would have downstream effects on the segmentation mask and the joint locations, so the PR would need to handle making such modifications as well.

@ShahryarSaljoughi
Copy link
Contributor Author

Thank you.
OK then I'm on it, I'll let you know when the PR is ready.
I'm new to open source contributions, I suppose I should close this issue as it has met its purpose, I'll open a new issue when the PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants