Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added spatial bbox helper #171

Closed
wants to merge 16 commits into from
Closed

Added spatial bbox helper #171

wants to merge 16 commits into from

Conversation

membriux
Copy link
Contributor

@membriux membriux commented Dec 8, 2021

Summary

  • I have read CONTRIBUTING.md to understand how to contribute to this repository :)

Computes the bbox that encloses a white box in a black background for any augmentation.

Image

python -m unittest discover -s augly/tests/image_tests/ -p "*_test.py"
# Or `python -m unittest discover -s augly/tests/image_tests/ -p "*.py"` to run pytorch test too (must install `torchvision` to run)
Ran 82 tests in 53.014s

OK (skipped=5)

Other testing

Colab notebook testing the bbox helper → https://colab.research.google.com/drive/1g_0I6f_bv4Wsna6l9jjZrOJ62a4dpu8U#scrollTo=yUczCe6FU9Bs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2021
zpapakipos
zpapakipos requested changes Dec 8, 2021
View reviewed changes
augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
@membriux @zpapakipos
Update augly/image/utils/bboxes.py
fca642f 
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

@zpapakipos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@membriux @zpapakipos
Update augly/image/utils/bboxes.py
a6af189 
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@membriux @zpapakipos
Update augly/image/utils/bboxes.py
eed0dea 
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@membriux
remove dummy image function
743df45 
Added dummy image functionality inside spatial_bbox
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@membriux @zpapakipos
Update augly/image/utils/bboxes.py
09d8516 
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@membriux @zpapakipos
Update augly/image/utils/bboxes.py
4f9b20c 
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@zpapakipos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

jbitton
jbitton reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@jbitton jbitton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm! just three tiny comments on my end and we can land!

augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
augly/image/utils/bboxes.py Outdated Show resolved Hide resolved
@membriux @jbitton
Update augly/image/utils/bboxes.py
9f2d371 
Co-authored-by: Joanna Bitton <joanna.bitton@gmail.com>
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@membriux @jbitton
Update augly/image/utils/bboxes.py
482de83 
Co-authored-by: Joanna Bitton <joanna.bitton@gmail.com>
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

@membriux @jbitton
Update augly/image/utils/bboxes.py
3ecd59b 
Co-authored-by: Joanna Bitton <joanna.bitton@gmail.com>
@facebook-github-bot
Copy link
Contributor

@membriux has updated the pull request. You must reimport the pull request before landing.

zpapakipos
zpapakipos approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@zpapakipos zpapakipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the requested changes!

@facebook-github-bot
Copy link
Contributor

@zpapakipos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbitton jbitton jbitton left review comments

@zpapakipos zpapakipos zpapakipos approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@membriux @facebook-github-bot @zpapakipos @jbitton