global reasoning unit #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
e285314
to
cc4f38b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
cc4f38b
to
2bbe46f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
2bbe46f
to
5abf6cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
5abf6cf
to
243c5dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
243c5dc
to
1fa2702
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
1fa2702
to
00706d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
00706d7
to
5ebfda4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
5ebfda4
to
8401250
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
8401250
to
1120927
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
1120927
to
91c0214
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
stephenyan1231
force-pushed
the
export-D18344566
branch
from
91c0214
to
f2a6eee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
Summary: Pull Request resolved: facebookresearch/ClassyVision#181 - Implement Global Reasoning Networks (`glore`) (https://arxiv.org/abs/1811.12814). The reference implementation is on Github (https://github.com/facebookresearch/GloRe) - For now, we don't plan to open source `glore`. Thus, we implement a `ProdResNeXt3D` model in `prod_resnext3d.py`. Refactor `ResNeXt3D` to reduce the duplicate code between `ResNeXt3D` and `ProdResNeXt3D`. - In the long-run, we are more flexible to add more implementation to `ProdResNeXt3D` to meet prod needs while keeping the open source `ResNeXt3D` implementation minimal. - Rename the json configs to tell whether glore is `on` or `off`. Therefore - `train_kinetics400_glore_off_i3d50` means `glore` is off, but we use the baseline I3D-50 model in `glore` paper. - `train_kinetics400_glore_on_i3d50` means `glore` is on and `glore` units are inserted into baseline I3D-50 model. - Similar changes are made to SlowFast `sf` json config. Since we only implement baseline I3D model used in SF, which is a slightly different I3D model from I3D model in `glore`, it is always `off`. Reviewed By: vreis Differential Revision: D18344566 fbshipit-source-id: fac0fe090f7814e5aa41d5be5ff29f198147a27d
stephenyan1231
force-pushed
the
export-D18344566
branch
from
f2a6eee
to
b6d453a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18344566 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2019
Summary: Pull Request resolved: #181 - Implement Global Reasoning Networks (`glore`) (https://arxiv.org/abs/1811.12814). The reference implementation is on Github (https://github.com/facebookresearch/GloRe) - For now, we don't plan to open source `glore`. Thus, we implement a `ProdResNeXt3D` model in `prod_resnext3d.py`. Refactor `ResNeXt3D` to reduce the duplicate code between `ResNeXt3D` and `ProdResNeXt3D`. - In the long-run, we are more flexible to add more implementation to `ProdResNeXt3D` to meet prod needs while keeping the open source `ResNeXt3D` implementation minimal. - Rename the json configs to tell whether glore is `on` or `off`. Therefore - `train_kinetics400_glore_off_i3d50` means `glore` is off, but we use the baseline I3D-50 model in `glore` paper. - `train_kinetics400_glore_on_i3d50` means `glore` is on and `glore` units are inserted into baseline I3D-50 model. - Similar changes are made to SlowFast `sf` json config. Since we only implement baseline I3D model used in SF, which is a slightly different I3D model from I3D model in `glore`, it is always `off`. Reviewed By: vreis Differential Revision: D18344566 fbshipit-source-id: ccf27f732a0839d3dfe93afb54c9ce05d1833cf6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
glore) (https://arxiv.org/abs/1811.12814). The reference implementation is on Github (https://github.com/facebookresearch/GloRe)onoroff. Thereforetrain_kinetics400_glore_off_i3d50meansgloreis off, but we use the baseline I3D-50 model inglorepaper.train_kinetics400_glore_on_i3d50meansgloreis on andgloreunits are inserted into baseline I3D-50 model.sfjson config. Since we only implement baseline I3D model used in SF, which is a slightly different I3D model from I3D model inglore, it is alwaysoff.Differential Revision: D18344566