[llvm] Adding missing global initializers when splitting a benchmark #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #775 +/- ##
================================================
- Coverage 89.01% 48.71% -40.31%
================================================
Files 131 131
Lines 8065 8074 +9
================================================
- Hits 7179 3933 -3246
- Misses 886 4141 +3255
|
ChrisCummins
force-pushed
the
feature/split-merge-integration-tests
branch
from
a09aef7
to
b4c48e2
Compare
All other make targets igore `examples/` since it has its own Makefile.
This provides compatibility with environments which do not have Python 3.8 available.
ChrisCummins
force-pushed
the
feature/split-merge-integration-tests
branch
from
b4c48e2
to
bea46ba
Compare
If the function being extracted has `available_externally` linkage, DCE will delete it, producing an empty file.
This adds support for custom benchmarks.
ChrisCummins
force-pushed
the
feature/split-merge-integration-tests
branch
from
bea46ba
to
b4a0da1
Compare
ChrisCummins
force-pushed
the
feature/split-merge-integration-tests
branch
from
b4a0da1
to
1faec6b
Compare
ChrisCummins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split_benchmark_by_function()so that it returns an extra "benchmark", which is a single module containing no executable instructions, but all global variable definitions. This is needed to make the result of merging the split benchmarks compilable.split_benchmark_by_function()whereby the definitions for functions marked withavailable_externallylinkage were dropped.-stripand-strip-nondebug, which are unsafe to run before split+merge.Follow up to #772.