Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible data leak in lvis_v1_train_cat_info.json #79

Open
wusize opened this issue Sep 16, 2022 · 2 comments
Open

Possible data leak in lvis_v1_train_cat_info.json #79

wusize opened this issue Sep 16, 2022 · 2 comments

Comments

@wusize
Copy link

wusize commented Sep 16, 2022

Hi, Xinyi!

I loaded the file "lvis_v1_train_cat_info.json", it seems to contain image_count for rare classes. It may lead to data leak in the open-vocabulary setting when using the fed loss.

@xingyizhou
Copy link
Contributor

Hi Size,

Thank you for bring up this. I remembered I noted this issue, but thought we could ignore this because the zero-shot embeddings in the FedLoss will never receive a positive loss. They will receive negative losses (and thus have a negative impact on the performance), but these are rare due to the design of Fedloss. I should have tried to remove them in the loss but it was likely not better since I used this in the final version. Please feel free to try the corrected version and post numbers if you find a considerable difference. Thanks!

Best,
Xingyi

@wusize
Copy link
Author

wusize commented Sep 19, 2022

OK. Thanks for your response! It seems not likely to influence the FedLoss. But I still recommend to push a correct version of lvis_v1_train_cat_info.json that records 0 for novel classes. Otherwise, when setting ignore_zero_class = True for ce and bce loss, there would be some problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants