Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move optimizer_test_utils to optimizers directory #18

Closed
wants to merge 2 commits into from

Conversation

jessemin
Copy link
Contributor

@jessemin jessemin commented Nov 8, 2021

Summary: it is currently located at the top-level tests directory. However the top-level tests directory does not really make sense as each component is organized into its dedicated directory. optimizer_test_utils.py belongs to the optimizer directory in that sense. In this diff, we move the file to the optimizer directory and fixes the reference.

Differential Revision: D32241821

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Nov 8, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32241821

Summary: as title

Differential Revision: D32241746

fbshipit-source-id: bd2afc80002f0855fb4a50c7d7d5e34903cf05bf
Summary:
Pull Request resolved: facebookresearch/FLSim#18

it is currently located at the top-level `tests` directory. However the top-level `tests` directory does not really make  sense as each component is organized into its dedicated directory. `optimizer_test_utils.py` belongs to the `optimizer` directory in that sense. In this diff, we move the file to the `optimizer` directory and fixes the reference.

Differential Revision: D32241821

fbshipit-source-id: 77051d22b44a5a136518183ca279234f06e961ac
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32241821

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a40ead1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants