New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix#36: fix imports in tests. #37
Conversation
Hi @ghaccount! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thanks for the PR @ghaccount ! |
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to remove this test as well test_sync_trainer_with_page_data_provider
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
2 similar comments
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Types of changes
Motivation and Context / Related issue
Bug Fix#36: fix imports in tests.
How Has This Been Tested (if it applies)
pytest -ra is able to discover all tests now.
Checklist