Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having to import flsim.configs before creating config from json is unintuitive #39

Open
JohnlNguyen opened this issue Mar 9, 2022 · 0 comments
Assignees

Comments

@JohnlNguyen
Copy link
Contributor

馃殌 Feature

This code works

import flsim.configs <-- 
from flsim.utils.config_utils import fl_config_from_json

json_config = {
    "trainer": {
    }
}
cfg = fl_config_from_json(json_config)

This code doesn't work

from flsim.utils.config_utils import fl_config_from_json

json_config = {
    "trainer": {
    }
}
cfg = fl_config_from_json(json_config)

Motivation

Having to import flsim.configs is unintuitive and not clear from the user perspective

Pitch

Alternatives

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants