Reimplement MDNRNN using new gym. #253

kaiwenw · 2020-05-04T18:24:38Z

Using our new gym, test MDNRNN feature importance/sensitivity.
Also, train DQN to play POMDP string game with states embedded
with MDNRNN. This is in preparation to nuke old gym folder.

facebook-github-bot

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 51b295666b7ab9aff2bc8a302df768ea2d13d22c

facebook-github-bot · 2020-05-04T19:04:02Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 9675bc8629f4663b75f09b382e751d6f04a10a53

facebook-github-bot · 2020-05-04T19:36:08Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 52cf3586838e1513546d39c4afcc2fe1db7781c8

facebook-github-bot · 2020-05-04T19:56:32Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 4257c419a77ece6b4a6a6976da6015e8fb4aa008

facebook-github-bot · 2020-05-04T21:20:17Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: aa23f16b8c222c970b11d719bfbb30b9d5a85aa2

facebook-github-bot · 2020-05-04T21:58:57Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 391052248ba24ae80663a0904f0a6ad8921d8204

facebook-github-bot · 2020-05-04T22:47:43Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 982ae67cb2d3f8187b20c957bbe3299757b788bb

facebook-github-bot · 2020-05-04T23:21:10Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: ddd4477959bb7973d1d30200e626717d995d8f21

facebook-github-bot · 2020-05-04T23:54:36Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 9c1e70babe4fa3613650edf9a44a93b45feda3e7

facebook-github-bot · 2020-05-05T00:21:24Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 598f2bebcc9e3599afed71ce0eee1898f4ac7eaa

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: f5290b53ad95ee27b1ecfa1a39973f4c0abf9e0f

facebook-github-bot · 2020-05-05T23:54:02Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 437efcc47ae5184ff9ab7be5c94a4be6e8a4e98e

facebook-github-bot · 2020-05-06T00:31:31Z

This pull request was exported from Phabricator. Differential Revision: D21385499

codecov-io · 2020-05-06T00:46:02Z

Codecov Report

Merging #253 into master will decrease coverage by 0.76%.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   84.46%   83.70%   -0.77%     
==========================================
  Files         222      225       +3     
  Lines       14636    14608      -28     
  Branches       42       42              
==========================================
- Hits        12362    12227     -135     
- Misses       2250     2357     +107     
  Partials       24       24

Impacted Files	Coverage Δ
reagent/gym/envs/dynamics/linear_dynamics.py	`100.00% <ø> (ø)`
reagent/gym/policies/samplers/discrete_sampler.py	`50.00% <0.00%> (+10.86%)`	⬆️
reagent/test/environment/__init__.py	`100.00% <ø> (ø)`
reagent/gym/policies/random_policies.py	`55.93% <50.00%> (+25.74%)`	⬆️
reagent/test/gym/open_ai_gym_environment.py	`47.34% <50.00%> (-26.58%)`	⬇️
reagent/test/world_model/test_mdnrnn.py	`98.87% <66.66%> (ø)`
...eagent/workflow/model_managers/world_model_base.py	`77.41% <77.41%> (ø)`
reagent/gym/tests/utils.py	`80.00% <80.00%> (ø)`
...workflow/model_managers/model_based/world_model.py	`90.47% <90.47%> (ø)`
reagent/gym/envs/pomdp/state_embed_env.py	`93.33% <93.33%> (ø)`
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd71aca...7410c9c. Read the comment docs.

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: a4fa462ecdd5352e4cbb7cbb956517fcdf0f1502

facebook-github-bot · 2020-05-06T02:35:29Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Reviewed By: czxttkl Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: ff1f07a780e532897baf23d34ce76712a4a5dda9

facebook-github-bot · 2020-05-06T06:48:30Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Reviewed By: czxttkl Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: c8a89a7c6b645c8416c5a222aa13afab40fc2b75

facebook-github-bot · 2020-05-06T06:57:37Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: bba71931a578597defa8dff79fd4b2ed193f8fb9

facebook-github-bot · 2020-05-06T16:13:51Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: 1d7d8c1ba7cd4d0636ba45a871a8ac02073ae166

facebook-github-bot · 2020-05-06T17:32:44Z

This pull request was exported from Phabricator. Differential Revision: D21385499

Summary: Using our new gym, test MDNRNN feature importance/sensitivity. Also, train DQN to play POMDP string game with states embedded with MDNRNN. This is in preparation to nuke old gym folder. Pull Request resolved: facebookresearch#253 Differential Revision: D21385499 Pulled By: kaiwenw fbshipit-source-id: e7b1f87630fe89ebc9c4062bf3775705a761f46f

facebook-github-bot · 2020-05-06T17:52:48Z

This pull request was exported from Phabricator. Differential Revision: D21385499

facebook-github-bot · 2020-05-06T21:24:38Z

@kaiwenw merged this pull request in e60511a.

facebook-github-bot reviewed May 4, 2020

View reviewed changes

kaiwenw force-pushed the mdnrnn branch from 0b18c08 to 6732126 Compare May 4, 2020 19:04

kaiwenw force-pushed the mdnrnn branch from 6732126 to a452390 Compare May 4, 2020 19:36

kaiwenw force-pushed the mdnrnn branch from a452390 to 41fb87d Compare May 4, 2020 19:56

kaiwenw force-pushed the mdnrnn branch from 41fb87d to cef132d Compare May 4, 2020 21:20

kaiwenw force-pushed the mdnrnn branch from cef132d to b6acb1e Compare May 4, 2020 21:58

kaiwenw force-pushed the mdnrnn branch from b6acb1e to dc5283a Compare May 4, 2020 22:47

kaiwenw force-pushed the mdnrnn branch from dc5283a to d7934e0 Compare May 4, 2020 23:21

kaiwenw force-pushed the mdnrnn branch from d7934e0 to 1f9261c Compare May 4, 2020 23:54

kaiwenw force-pushed the mdnrnn branch from 1f9261c to 6ede182 Compare May 5, 2020 00:21

kaiwenw force-pushed the mdnrnn branch from 6ede182 to 2b9a4a4 Compare May 5, 2020 06:53

kaiwenw force-pushed the mdnrnn branch from 53f03e5 to f04493e Compare May 5, 2020 23:53

kaiwenw force-pushed the mdnrnn branch from f04493e to 7410c9c Compare May 6, 2020 00:31

kaiwenw force-pushed the mdnrnn branch from 7410c9c to c5b5666 Compare May 6, 2020 02:35

kaiwenw force-pushed the mdnrnn branch from c5b5666 to c49de8f Compare May 6, 2020 06:48

kaiwenw force-pushed the mdnrnn branch from c49de8f to 4263e82 Compare May 6, 2020 06:57

kaiwenw force-pushed the mdnrnn branch from 4263e82 to 7cafab0 Compare May 6, 2020 16:13

kaiwenw force-pushed the mdnrnn branch from 7cafab0 to f34b803 Compare May 6, 2020 17:32

kaiwenw force-pushed the mdnrnn branch from f34b803 to 89dddb9 Compare May 6, 2020 17:52

facebook-github-bot closed this in e60511a May 6, 2020

facebook-github-bot added the Merged label May 6, 2020

kaiwenw deleted the mdnrnn branch May 8, 2020 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reimplement MDNRNN using new gym. #253

Reimplement MDNRNN using new gym. #253

kaiwenw commented May 4, 2020

facebook-github-bot left a comment

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 5, 2020

facebook-github-bot commented May 5, 2020

facebook-github-bot commented May 6, 2020

codecov-io commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

Reimplement MDNRNN using new gym. #253

Reimplement MDNRNN using new gym. #253

Conversation

kaiwenw commented May 4, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 4, 2020

facebook-github-bot commented May 5, 2020

facebook-github-bot commented May 5, 2020

facebook-github-bot commented May 6, 2020

codecov-io commented May 6, 2020

Codecov Report

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020

facebook-github-bot commented May 6, 2020