Fix the UnicodeDecodeError in np.loadtxt
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n position 1983: character maps to <undefined>` error in `np.loadtxt`.
facebook-github-bot
added
the
CLA Signed
|
Thank you @dmitrijsk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a corrected version of PR #8)
On Windows 10
np.loadtxtraisesUnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 1983: character maps to <undefined>.On CentOS 7:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 858: ordinal not in range(128)Specifying the UTF-8 encoding fixes the problem. Tested on Windows 10 and CentOS 7.
In contributing guidelines you ask for tests. But I'm not sure what kind of tests should I add since there are no other tests in the repo. Happy to do that if you clarify this point. I completed the CLA.