-tblog interprets nearly all inputs as True

[stephenroller]

Currently, passing anything but the explicit empty string to -tblog sets the option to True, due to how bool(string) works in Python. This currently is inconsistent with the rest of ParlAI.

ParlAI/parlai/core/logs.py

Line 28 in d97ff00

logger.add_argument('-tblog', '--tensorboard-log', type=bool, default=False,

This should be type='bool'. The rest of ParlAI uses this in order to interpet explicit arguments like y, n, false, ... as the values.

See

ParlAI/parlai/core/params.py

Line 298 in d97ff00

'--hide-labels', default=False, type='bool',

[uralik]

got it, thanks for the catch!