Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of the generated music with MAGNeT is worst than the one on the website and even from MusicGen. #440

Open
tachev opened this issue Mar 23, 2024 · 1 comment

Comments

@tachev
Copy link

tachev commented Mar 23, 2024

I love how quickly it creates the music.

What am I doing wrong?

I just run the samples that were provided and played with the settings, but no luck to get even close to the advertised quality. The sound is good, but the music is very strange.
I tried with changing the params, but that made it worst.
model.set_generation_params(
use_sampling=True,
top_k=0,
top_p=0.9,
temperature=3.0,
max_cfg_coef=10.0,
min_cfg_coef=1.0,
decoding_steps=[int(20 * model.lm.cfg.dataset.segment_duration // 10), 10, 10, 10],
span_arrangement='stride1'
)

medium is a little bit better but still not as close to anything that I heard from other models

@yukara-ikemiya
Copy link

yukara-ikemiya commented Mar 24, 2024

I also had the same impression on MAGNeT and found that an author answered why MAGNeT performance is worse than the audio samples in demo page here.
[About Magnet‘s performance] : #395

As the author mentioned, "rescoring technique using MusicGen" (they haven't provided in this repository) should improve performance at inference time. And what we get now is the non-rescoring version in Table 3 in the paper.

In addition to this, I'm thinking the following based on the paper..

  1. MAGNeT is faster, but the performance is still worse than MusicGen originally (Table 1).
  2. The current metrics of music generative model (FAD, CLAP score, ets..) are not perfect. It seems that they can be easily cheated and the metrics value does't reflect the generation quality directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants