Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down dependencies, and only pin down minimal version #75

Closed
NicolasHug opened this issue Jul 6, 2021 · 0 comments
Closed

Trim down dependencies, and only pin down minimal version #75

NicolasHug opened this issue Jul 6, 2021 · 0 comments

Comments

@NicolasHug
Copy link

Related to #65

There seems to be a lot of dependencies in requirements.txt that are actually not needed. For example scikit-learn, numba, joblib, threadpoolctl, six, etc. are not used and could be removed. There are probably a bunch of others, I didn't check them all.

Also, all dependencies are pinned-down to a specific version, e.g. Pillow==8.2.0. Unless there are very specific reasons to do so, it is preferable to only pin down the minimal version e.g. Pillow>=8.2.0 to allow for more flexibility in terms of environment setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants